Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed02d083824ec2e28478fb820124bcafa9e08997
      
https://github.com/WebKit/WebKit/commit/ed02d083824ec2e28478fb820124bcafa9e08997
  Author: Megan Gardner <[email protected]>
  Date:   2025-04-02 (Wed, 02 Apr 2025)

  Changed paths:
    A 
LayoutTests/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html
    A 
LayoutTests/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation.html
    A 
LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html
    A 
LayoutTests/platform/mac-wk1/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html
    A 
LayoutTests/platform/win/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html
    A 
LayoutTests/platform/wpe/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html
    M Source/WebCore/page/LocalFrameView.cpp

  Log Message:
  -----------
  Navigation to a different text fragment on a page leaves the first 
highlighted.
rdar://142968610
https://bugs.webkit.org/show_bug.cgi?id=290664

Reviewed by Aditya Keerthi and BJ Burg.

The storage for the fragment highlights is never cleared.
This normally isn't an issue because it's not common
for pages to navigate internally using fragments, but if
they do, the highlights will never be cleared. Clear
the registry before filling it with the recently parsed
and located ranges.

* 
LayoutTests/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html:
 Added.
* 
LayoutTests/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation.html:
 Added.
* 
LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html:
 Added.
* 
LayoutTests/platform/mac-wk1/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html:
 Added.
* 
LayoutTests/platform/win/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html:
 Added.
* 
LayoutTests/platform/wpe/http/tests/scroll-to-text-fragment/clear-on-new-fragment-navigation-expected.html:
 Added.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::scrollToFragment):

Canonical link: https://commits.webkit.org/293110@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to