Title: [112474] trunk/Source
Revision
112474
Author
[email protected]
Date
2012-03-28 16:55:31 -0700 (Wed, 28 Mar 2012)

Log Message

Remove dispatchDidLoadMainResource callback, since no
port implements it.
https://bugs.webkit.org/show_bug.cgi?id=82539

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, just deleting dead code.

* loader/EmptyClients.h:
(EmptyFrameLoaderClient):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoading):
(WebCore::FrameLoader::mainReceivedCompleteError):
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):

Source/WebKit/blackberry:

* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit):
* WebCoreSupport/FrameLoaderClientGtk.h:
(FrameLoaderClient):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.order:

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit):
* WebCoreSupport/FrameLoaderClientWinCE.h:
(FrameLoaderClientWinCE):

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore):
* WebKitSupport/FrameLoaderClientWx.h:
(FrameLoaderClientWx):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (112473 => 112474)


--- trunk/Source/WebCore/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,24 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        No new tests, just deleting dead code.
+
+        * loader/EmptyClients.h:
+        (EmptyFrameLoaderClient):
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::finishedLoading):
+        (WebCore::FrameLoader::mainReceivedCompleteError):
+        * loader/FrameLoaderClient.h:
+        (FrameLoaderClient):
+        * loader/MainResourceLoader.cpp:
+        (WebCore::MainResourceLoader::receivedError):
+        (WebCore::MainResourceLoader::didCancel):
+
 2012-03-28  Enrica Casucci  <[email protected]>
 
         REGRESSION: editing/pasteboard/dataTransfer-setData-getData.html fails on Mac platforms.

Modified: trunk/Source/WebCore/loader/EmptyClients.h (112473 => 112474)


--- trunk/Source/WebCore/loader/EmptyClients.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebCore/loader/EmptyClients.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -305,7 +305,6 @@
     virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
     virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>) { }
 
-    virtual void dispatchDidLoadMainResource(DocumentLoader*) { }
     virtual void revertToProvisionalState(DocumentLoader*) { }
     virtual void setMainDocumentError(DocumentLoader*, const ResourceError&) { }
 

Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (112473 => 112474)


--- trunk/Source/WebCore/loader/FrameLoader.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1983,7 +1983,6 @@
     if (!dl->mainDocumentError().isNull() || !dl->frameLoader())
         return;
     dl->setPrimaryLoadComplete(true);
-    m_client->dispatchDidLoadMainResource(dl.get());
     checkLoadComplete();
 }
 
@@ -3085,7 +3084,6 @@
 void FrameLoader::mainReceivedCompleteError(DocumentLoader* loader, const ResourceError&)
 {
     loader->setPrimaryLoadComplete(true);
-    m_client->dispatchDidLoadMainResource(activeDocumentLoader());
     checkCompleted();
     if (m_frame->page())
         checkLoadComplete();

Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (112473 => 112474)


--- trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -179,7 +179,6 @@
         virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) = 0;
         virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>) = 0;
 
-        virtual void dispatchDidLoadMainResource(DocumentLoader*) = 0;
         virtual void revertToProvisionalState(DocumentLoader*) = 0;
         virtual void setMainDocumentError(DocumentLoader*, const ResourceError&) = 0;
 

Modified: trunk/Source/WebKit/blackberry/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,14 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
+        (FrameLoaderClientBlackBerry):
+
 2012-03-28  Leo Yang  <[email protected]>
 
         [BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp

Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h (112473 => 112474)


--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -93,7 +93,6 @@
     virtual void cancelPolicyCheck();
     virtual void dispatchUnableToImplementPolicy(const ResourceError&) { notImplemented(); }
     virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
-    virtual void dispatchDidLoadMainResource(DocumentLoader*) { notImplemented(); }
     virtual void revertToProvisionalState(DocumentLoader*) { notImplemented(); }
     virtual void setMainDocumentError(DocumentLoader*, const ResourceError&);
     virtual void postProgressStartedNotification();

Modified: trunk/Source/WebKit/chromium/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,16 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * src/FrameLoaderClientImpl.cpp:
+        (WebKit):
+        * src/FrameLoaderClientImpl.h:
+        (FrameLoaderClientImpl):
+
 2012-03-28  Dirk Pranke  <[email protected]>
 
         Roll chromium from 129300 to 129509.

Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp (112473 => 112474)


--- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1050,11 +1050,6 @@
     (m_webFrame->frame()->loader()->policyChecker()->*function)(PolicyUse);
 }
 
-void FrameLoaderClientImpl::dispatchDidLoadMainResource(DocumentLoader*)
-{
-    // FIXME
-}
-
 void FrameLoaderClientImpl::revertToProvisionalState(DocumentLoader*)
 {
     m_hasRepresentation = true;

Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h (112473 => 112474)


--- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -118,7 +118,6 @@
     virtual void dispatchUnableToImplementPolicy(const WebCore::ResourceError&);
     virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*);
     virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>);
-    virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
     virtual void revertToProvisionalState(WebCore::DocumentLoader*);
     virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
     virtual void willChangeEstimatedProgress() { }

Modified: trunk/Source/WebKit/efl/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/efl/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,16 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/FrameLoaderClientEfl.cpp:
+        (WebCore):
+        * WebCoreSupport/FrameLoaderClientEfl.h:
+        (FrameLoaderClientEfl):
+
 2012-03-27  Carlos Garcia Campos  <[email protected]>
 
         [SOUP] Implement missing methods in CookieJarSoup

Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp (112473 => 112474)


--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -628,11 +628,6 @@
     notImplemented();
 }
 
-void FrameLoaderClientEfl::dispatchDidLoadMainResource(DocumentLoader*)
-{
-    notImplemented();
-}
-
 void FrameLoaderClientEfl::revertToProvisionalState(DocumentLoader*)
 {
     m_hasRepresentation = true;

Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h (112473 => 112474)


--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -122,7 +122,6 @@
     virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
     virtual void dispatchWillSubmitForm(FramePolicyFunction, WTF::PassRefPtr<FormState>);
 
-    virtual void dispatchDidLoadMainResource(DocumentLoader*);
     virtual void revertToProvisionalState(DocumentLoader*);
     virtual void setMainDocumentError(DocumentLoader*, const ResourceError&);
 

Modified: trunk/Source/WebKit/gtk/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/gtk/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,16 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/FrameLoaderClientGtk.cpp:
+        (WebKit):
+        * WebCoreSupport/FrameLoaderClientGtk.h:
+        (FrameLoaderClient):
+
 2012-03-28  Carlos Garcia Campos  <[email protected]>
 
         [GTK] Implement PlatformStrategies

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp (112473 => 112474)


--- trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -882,11 +882,6 @@
         webkit_web_policy_decision_cancel(m_policyDecision);
 }
 
-void FrameLoaderClient::dispatchDidLoadMainResource(WebCore::DocumentLoader*)
-{
-    notImplemented();
-}
-
 void FrameLoaderClient::revertToProvisionalState(WebCore::DocumentLoader*)
 {
     m_hasRepresentation = true;

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h (112473 => 112474)


--- trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -105,7 +105,6 @@
         virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) { }
         virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, WTF::PassRefPtr<WebCore::FormState>);
 
-        virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
         virtual void revertToProvisionalState(WebCore::DocumentLoader*);
         virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
 

Modified: trunk/Source/WebKit/mac/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/mac/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,15 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/WebFrameLoaderClient.h:
+        * WebCoreSupport/WebFrameLoaderClient.mm:
+        * WebKit.order:
+
 2012-03-28  Joseph Pecoraro  <[email protected]>
 
         <http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL

Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h (112473 => 112474)


--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -127,7 +127,6 @@
     virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) OVERRIDE { }
     virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>) OVERRIDE;
 
-    virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*) OVERRIDE;
     virtual void revertToProvisionalState(WebCore::DocumentLoader*) OVERRIDE;
     virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&) OVERRIDE;
     virtual bool dispatchDidLoadResourceFromMemoryCache(WebCore::DocumentLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&, int length) OVERRIDE;

Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (112473 => 112474)


--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm	2012-03-28 23:55:31 UTC (rev 112474)
@@ -771,10 +771,6 @@
     [dictionary release];
 }
 
-void WebFrameLoaderClient::dispatchDidLoadMainResource(DocumentLoader* loader)
-{
-}
-
 void WebFrameLoaderClient::revertToProvisionalState(DocumentLoader* loader)
 {
     [dataSource(loader) _revertToProvisionalState];

Modified: trunk/Source/WebKit/mac/WebKit.order (112473 => 112474)


--- trunk/Source/WebKit/mac/WebKit.order	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/mac/WebKit.order	2012-03-28 23:55:31 UTC (rev 112474)
@@ -769,7 +769,6 @@
 __ZN20WebFrameLoaderClient29dispatchDidFinishDocumentLoadEv
 -[WebFrame(WebPrivate) _pendingFrameUnloadEventCount]
 __ZN20WebFrameLoaderClient29dispatchDidHandleOnloadEventsEv
-__ZN20WebFrameLoaderClient27dispatchDidLoadMainResourceEPN7WebCore14DocumentLoaderE
 __ZN20WebFrameLoaderClient21dispatchDidFinishLoadEv
 -[WebView(WebPrivate) _didFinishLoadForFrame:]
 -[WebView(WebPrivate) _didChangeBackForwardKeys]

Modified: trunk/Source/WebKit/qt/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/qt/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/qt/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,16 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/FrameLoaderClientQt.cpp:
+        (WebCore):
+        * WebCoreSupport/FrameLoaderClientQt.h:
+        (FrameLoaderClientQt):
+
 2012-03-20  Eric Seidel  <[email protected]>
 
         Move wtf/Platform.h from _javascript_Core to Source/WTF/wtf

Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (112473 => 112474)


--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -567,11 +567,6 @@
 }
 
 
-void FrameLoaderClientQt::dispatchDidLoadMainResource(DocumentLoader*)
-{
-}
-
-
 void FrameLoaderClientQt::revertToProvisionalState(DocumentLoader*)
 {
     m_hasRepresentation = true;

Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h (112473 => 112474)


--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -138,7 +138,6 @@
     virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
     virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
 
-    virtual void dispatchDidLoadMainResource(DocumentLoader*);
     virtual void revertToProvisionalState(DocumentLoader*);
     virtual void setMainDocumentError(DocumentLoader*, const ResourceError&);
 

Modified: trunk/Source/WebKit/win/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/win/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/win/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,15 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        * WebCoreSupport/WebFrameLoaderClient.h:
+        (WebFrameLoaderClient):
+
 2012-03-26  Adam Barth  <[email protected]>
 
         FrameLoader::shouldAllowNavigation uses Frame for context rather than Document

Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (112473 => 112474)


--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -460,10 +460,6 @@
         ui->webViewShow(webView);
 }
 
-void WebFrameLoaderClient::dispatchDidLoadMainResource(DocumentLoader*)
-{
-}
-
 void WebFrameLoaderClient::setMainDocumentError(DocumentLoader*, const ResourceError& error)
 {
     if (!m_manualLoader)

Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h (112473 => 112474)


--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -80,7 +80,6 @@
     virtual WebCore::Frame* dispatchCreatePage(const WebCore::NavigationAction&);
     virtual void dispatchShow();
 
-    virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
     virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
 
     virtual void postProgressStartedNotification();

Modified: trunk/Source/WebKit/wince/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/wince/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/wince/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,16 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
+        (WebKit):
+        * WebCoreSupport/FrameLoaderClientWinCE.h:
+        (FrameLoaderClientWinCE):
+
 2012-03-19  Adam Barth  <[email protected]>
 
         Remove support for "magic" iframe

Modified: trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp (112473 => 112474)


--- trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -396,11 +396,6 @@
     notImplemented();
 }
 
-void FrameLoaderClientWinCE::dispatchDidLoadMainResource(DocumentLoader*)
-{
-    notImplemented();
-}
-
 void FrameLoaderClientWinCE::revertToProvisionalState(DocumentLoader*)
 {
     notImplemented();

Modified: trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h (112473 => 112474)


--- trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -99,7 +99,6 @@
     virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) { }
     virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, WTF::PassRefPtr<WebCore::FormState>);
 
-    virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
     virtual void revertToProvisionalState(WebCore::DocumentLoader*);
     virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
 

Modified: trunk/Source/WebKit/wx/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit/wx/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/wx/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,16 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebKitSupport/FrameLoaderClientWx.cpp:
+        (WebCore):
+        * WebKitSupport/FrameLoaderClientWx.h:
+        (FrameLoaderClientWx):
+
 2012-03-25  Kevin Ollivier  <[email protected]>
 
         [wx] Unreviewed build fix. Add header needed for Unix builds.

Modified: trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp (112473 => 112474)


--- trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -385,12 +385,6 @@
 }
 
 
-void FrameLoaderClientWx::dispatchDidLoadMainResource(DocumentLoader*)
-{
-    notImplemented();
-}
-
-
 void FrameLoaderClientWx::revertToProvisionalState(DocumentLoader*)
 {
     notImplemented();

Modified: trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h (112473 => 112474)


--- trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -120,7 +120,6 @@
         virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
         virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
 
-        virtual void dispatchDidLoadMainResource(DocumentLoader*);
         virtual void revertToProvisionalState(DocumentLoader*);
 
         virtual void postProgressStartedNotification();

Modified: trunk/Source/WebKit2/ChangeLog (112473 => 112474)


--- trunk/Source/WebKit2/ChangeLog	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-28 23:55:31 UTC (rev 112474)
@@ -1,3 +1,14 @@
+2012-03-28  Nate Chapin  <[email protected]>
+
+        Remove dispatchDidLoadMainResource callback, since no
+        port implements it.
+        https://bugs.webkit.org/show_bug.cgi?id=82539
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+
 2012-03-28  Anders Carlsson  <[email protected]>
 
         Massive lag opening a link in a new background tab

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (112473 => 112474)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2012-03-28 23:55:31 UTC (rev 112474)
@@ -753,11 +753,6 @@
     webPage->send(Messages::WebPageProxy::WillSubmitForm(m_frame->frameID(), sourceFrame->frameID(), valuesVector, listenerID, InjectedBundleUserMessageEncoder(userData.get())));
 }
 
-void WebFrameLoaderClient::dispatchDidLoadMainResource(DocumentLoader*)
-{
-    notImplemented();
-}
-
 void WebFrameLoaderClient::revertToProvisionalState(DocumentLoader*)
 {
     notImplemented();

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h (112473 => 112474)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h	2012-03-28 23:43:19 UTC (rev 112473)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h	2012-03-28 23:55:31 UTC (rev 112474)
@@ -109,7 +109,6 @@
     virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) OVERRIDE { }
     virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>) OVERRIDE;
     
-    virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*) OVERRIDE;
     virtual void revertToProvisionalState(WebCore::DocumentLoader*) OVERRIDE;
     virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&) OVERRIDE;
     
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to