Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d131c3505c51e1c9bb14b75420aa43526c179742
https://github.com/WebKit/WebKit/commit/d131c3505c51e1c9bb14b75420aa43526c179742
Author: Brady Eidson <beid...@apple.com>
Date: 2025-04-04 (Fri, 04 Apr 2025)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/html/HTMLDialogElement.cpp
M Source/WebCore/html/HTMLElement.cpp
Log Message:
-----------
Cleanup some dialog and popover focus steps to bring in line with the spec
rdar://148533180
https://bugs.webkit.org/show_bug.cgi?id=291011
Reviewed by Ryosuke Niwa.
These autofocus-related steps were subtly wrong in how they chose the top
document on which to
clearAutofocusCandidates.
This patch fixes that up. With the great side benefit of removing some site
isolation concerns.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::sameOriginTopLevelTraversable const): This precise concept
is useful in at least
(3) call sites in autofocus code, and is likely to also be useful in other
places later.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::insertedIntoAncestor): Adopt sameOriginTopLevelTraversable.
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::runFocusingSteps): Adopt
sameOriginTopLevelTraversable.
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::runPopoverFocusingSteps): Adopt sameOriginTopLevelTraversable.
Canonical link: https://commits.webkit.org/293261@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
