Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83905fa0a630452ecbf7abf7b79d1aca8965c8cc
      
https://github.com/WebKit/WebKit/commit/83905fa0a630452ecbf7abf7b79d1aca8965c8cc
  Author: Devin Rousso <[email protected]>
  Date:   2025-03-23 (Sun, 23 Mar 2025)

  Changed paths:
    M 
LayoutTests/media/modern-media-controls/tracks-support/sorted-by-user-preferred-languages-expected.txt
    M 
LayoutTests/media/modern-media-controls/tracks-support/sorted-by-user-preferred-languages.html
    M Source/WebCore/page/CaptionUserPreferences.cpp
    M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp

  Log Message:
  -----------
  subtitle tracks with no `srclang` show up as " (label)" instead of just 
"label"
https://bugs.webkit.org/show_bug.cgi?id=290226

Reviewed by Eric Carlson.

* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::trackDisplayName):
Only use the localized format string if both parts are valid.

* Source/WebCore/page/CaptionUserPreferences.cpp:
(WebCore::trackDisplayName):
Strip any leading/trailing whitespace from the `label` before deciding whether 
to use it.

* 
LayoutTests/media/modern-media-controls/tracks-support/sorted-by-user-preferred-languages.html:
* 
LayoutTests/media/modern-media-controls/tracks-support/sorted-by-user-preferred-languages-expected.txt:

Canonical link: https://commits.webkit.org/292577@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to