Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b791573affbab202268645adf291fc44f98b30c
      
https://github.com/WebKit/WebKit/commit/7b791573affbab202268645adf291fc44f98b30c
  Author: Mike Wyrzykowski <[email protected]>
  Date:   2025-04-07 (Mon, 07 Apr 2025)

  Changed paths:
    M Source/WebGPU/WebGPU/HardwareCapabilities.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm

  Log Message:
  -----------
  [WebGPU] Debug metal device detection is failing on LegacySV iOS devices
https://bugs.webkit.org/show_bug.cgi?id=291218
rdar://148445495

Reviewed by Cameron McCormack.

The shader validation workaround added in 
https://bugs.webkit.org/show_bug.cgi?id=290739
was never applied on some devices since their MTLDevice name was 
MTLLegacySVDevice which
does not contain the string 'Debug'.

No test as LegacySV is only applicable to older iOS devices which are not run 
as part of EWS.

* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::isShaderValidationEnabled):
Check for both strings.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
This is needed on SV iOS devices too, in production we would never encounter 
this logic.

Canonical link: https://commits.webkit.org/293389@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to