Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 36bc13cd2769c34de02aee58a93ed29f7332a33e
https://github.com/WebKit/WebKit/commit/36bc13cd2769c34de02aee58a93ed29f7332a33e
Author: Frédéric Wang <fw...@igalia.com>
Date: 2025-04-08 (Tue, 08 Apr 2025)
Changed paths:
A
LayoutTests/fast/rendering/render-multi-column-set-invalidate-002-crash-expected.txt
A
LayoutTests/fast/rendering/render-multi-column-set-invalidate-002-crash.html
M Source/WebCore/rendering/RenderObject.cpp
Log Message:
-----------
Handle consecutive MultiColumnSets in
propagateRepaintToParentWithOutlineAutoIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=286931
rdar://148057180
Reviewed by Alan Baradlay.
Special code was added in https://commits.webkit.org/259412@main for
propagateRepaintToParentWithOutlineAutoIfNeeded() to handle placeholder
of MultiColumnSet. However, this code assumes the renderer argument of
findColumnSpannerPlaceholder() is necessarily a spanner if its previous
sibling is a MultiColumnSet, which is not the case in the reported
repro case. We align with RenderMultiColumnSet::requiresBalancing() and
skip the fix in that case. See bug 286931 for details.
*
LayoutTests/fast/rendering/render-multi-column-set-invalidate-002-crash-expected.txt:
Added.
* LayoutTests/fast/rendering/render-multi-column-set-invalidate-002-crash.html:
Added. Reduced from the original repro.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const):
Don't try getting a spanner in the bad case when the renderer it itself a
MultiColumnSet.
Originally-landed-as: 289651.3@webkit-2025.2-embargoed (90b6e2339664).
Canonical link: https://commits.webkit.org/293424@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
