Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8801f12419402594b4b2b66a282f75f7a36507d7
https://github.com/WebKit/WebKit/commit/8801f12419402594b4b2b66a282f75f7a36507d7
Author: Lily Spiniolas <[email protected]>
Date: 2025-04-08 (Tue, 08 Apr 2025)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/forms/color/input-color-parts-appearance-expected.html
A LayoutTests/fast/forms/color/input-color-parts-appearance.html
A
LayoutTests/fast/forms/color/input-color-swatch-overlay-appearance-expected.txt
A LayoutTests/fast/forms/color/input-color-swatch-overlay-appearance.html
M LayoutTests/platform/mac/TestExpectations
M LayoutTests/platform/mac/fast/forms/color/color-input-swatch-expected.txt
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/css/html.css
M Source/WebCore/platform/StyleAppearance.cpp
M Source/WebCore/platform/StyleAppearance.h
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
[macOS] Add style adjustment methods and paint method for color swatch for
vector-based controls
https://bugs.webkit.org/show_bug.cgi?id=290776#
rdar://148261180
Reviewed by Aditya Keerthi.
Updated support for the vector-based color control. Added new StyleAppearances
`ColorWellSwatch`, `ColorWellSwatchOverlay`, and `ColorWellSwatchWrapper`
so that style adjustments can be performed on the input's shadow DOM elements
as needed, and so that the color swatch can be painted if needed.
Updated Mac test expectations for fast/forms/color/color-input-swatch.html
to include the new user agent part.
Added two new layout tests. `input-color-swatch-overlay-appearance.html`
ensures that, when the color swatch has `appearance: none`, the color
swatch overlay has a used appearance of 'none'. This is done by inferring
the used appearance based on the overlay's computed styles.
`input-color-parts-appearance.html` ensures that a color input with
style `appearance: none` displays the same as a color input with
`appearance: none` set for the input, its color swatch wrapper,
and its color swatch.
* LayoutTests/TestExpectations:
* LayoutTests/fast/forms/color/input-color-parts-appearance-expected.html:
Added.
* LayoutTests/fast/forms/color/input-color-parts-appearance.html: Added.
*
LayoutTests/fast/forms/color/input-color-swatch-overlay-appearance-expected.txt:
Added.
* LayoutTests/fast/forms/color/input-color-swatch-overlay-appearance.html:
Added.
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/mac/fast/forms/color/color-input-swatch-expected.txt:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/html.css:
(input[type="color"]::-internal-color-swatch-overlay):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
* Source/WebCore/platform/StyleAppearance.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/StyleAppearance.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::parentOfElementUsesPrimitiveAppearance):
(WebCore::RenderTheme::adjustAppearanceForElement const):
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::autoAppearanceForElement const):
(WebCore::RenderTheme::createControlPart const):
(WebCore::RenderTheme::paint):
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::adjustColorWellSwatchStyle const):
(WebCore::RenderTheme::adjustColorWellSwatchOverlayStyle const):
(WebCore::RenderTheme::adjustColorWellSwatchWrapperStyle const):
(WebCore::RenderTheme::paintColorWellSwatch):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::adjustColorWellSwatchStyle const):
(WebCore::RenderThemeCocoa::adjustColorWellSwatchOverlayStyle const):
(WebCore::RenderThemeCocoa::adjustColorWellSwatchWrapperStyle const):
(WebCore::RenderThemeCocoa::paintColorWellSwatch):
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::createColorWellSwatchSubtree):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Canonical link: https://commits.webkit.org/293442@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
