Title: [112527] trunk/Source/WebCore
Revision
112527
Author
[email protected]
Date
2012-03-29 06:24:36 -0700 (Thu, 29 Mar 2012)

Log Message

Web Inspector: timeline overview window selection is not reset upon clear/record
https://bugs.webkit.org/show_bug.cgi?id=82603

Reviewed by Pavel Feldman.

- TimelineOverviewPane.reset() -> _reset();
- perform update() from reset();
- perform reset() upon RecordsCleared event from the model.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._renderBars):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
* inspector/front-end/timelinePanel.css:
(.timeline-vertical-overview-bars):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (112526 => 112527)


--- trunk/Source/WebCore/ChangeLog	2012-03-29 12:53:08 UTC (rev 112526)
+++ trunk/Source/WebCore/ChangeLog	2012-03-29 13:24:36 UTC (rev 112527)
@@ -1,3 +1,25 @@
+2012-03-29  Andrey Kosyakov  <[email protected]>
+
+        Web Inspector: timeline overview window selection is not reset upon clear/record
+        https://bugs.webkit.org/show_bug.cgi?id=82603
+
+        Reviewed by Pavel Feldman.
+
+        - TimelineOverviewPane.reset() -> _reset();
+        - perform update() from reset();
+        - perform reset() upon RecordsCleared event from the model.
+
+        * inspector/front-end/TimelineOverviewPane.js:
+        (WebInspector.TimelineOverviewPane):
+        (WebInspector.TimelineOverviewPane.prototype._reset):
+        (WebInspector.TimelineVerticalOverview):
+        (WebInspector.TimelineVerticalOverview.prototype.update):
+        (WebInspector.TimelineVerticalOverview.prototype._renderBars):
+        (WebInspector.TimelineVerticalOverview.prototype._renderBar):
+        (WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
+        * inspector/front-end/timelinePanel.css:
+        (.timeline-vertical-overview-bars):
+
 2012-03-29  Zalan Bujtas  <[email protected]>
 
         Remove redundant updateViewportArguments() call when page is restored from page cache.

Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (112526 => 112527)


--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2012-03-29 12:53:08 UTC (rev 112526)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2012-03-29 13:24:36 UTC (rev 112527)
@@ -111,7 +111,7 @@
     this._overviewCalculator = new WebInspector.TimelineOverviewCalculator();
 
     model.addEventListener(WebInspector.TimelineModel.Events.RecordAdded, this._scheduleRefresh, this);
-    model.addEventListener(WebInspector.TimelineModel.Events.RecordsCleared, this._update, this);
+    model.addEventListener(WebInspector.TimelineModel.Events.RecordsCleared, this._reset, this);
 }
 
 WebInspector.TimelineOverviewPane.MinSelectableSize = 12;
@@ -277,7 +277,7 @@
         this._topPaneSidebarElement.style.width = width + "px";
     },
 
-    reset: function()
+    _reset: function()
     {
         this._windowStartTime = 0;
         this._windowEndTime = Infinity;
@@ -286,6 +286,7 @@
         this._overviewGrid.updateDividers(true, this._overviewCalculator);
         if (this._verticalOverview)
             this._verticalOverview.reset();
+        this._update();
     },
 
     scrollWindow: function(event)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to