Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b3f95c644b3ba88d2ed59c4023997329c2af80ba
https://github.com/WebKit/WebKit/commit/b3f95c644b3ba88d2ed59c4023997329c2af80ba
Author: Sihui Liu <[email protected]>
Date: 2025-04-10 (Thu, 10 Apr 2025)
Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations
M LayoutTests/storage/indexeddb/modern/resources/blob-cursor2.html
M LayoutTests/storage/indexeddb/modern/resources/blob-svg-image2.html
Log Message:
-----------
[Site Isolation] Make storage/indexeddb/modern/blob-cursor.html pass on bot
https://bugs.webkit.org/show_bug.cgi?id=291326
Reviewed by Ben Nham.
When running this test in cross-origin iframe, exception will be thrown in
IDBTransaction creation, because new window
created by `window.open` does not use the same storage partition and its opener
and target object store cannot be found.
The error will be handled by global error event handler, where
TestRunner::notifyDone() is called and console log about
uncaught exception will be printed.
When site isolation is disabled, result dumping will be immediate (web process
=> UI process), so the result does not
have the error console log. When site isolation is enabled, result dumping will
be async (subframe process => UI process
=> main frame process => UI process), so console log will be sent from subframe
process to UI process and will be
included in result. This has led to test failure when running tests with
--site-isolation.
To fix this, now we explicitly catch the error in test, so that it will have a
more deterministic result regardless of
the implementation.
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/storage/indexeddb/modern/resources/blob-cursor2.html:
* LayoutTests/storage/indexeddb/modern/resources/blob-svg-image2.html:
Canonical link: https://commits.webkit.org/293524@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
