Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9d6166d09630f34d4ba523ad0d52bb3d74fe2376
https://github.com/WebKit/WebKit/commit/9d6166d09630f34d4ba523ad0d52bb3d74fe2376
Author: Sihui Liu <[email protected]>
Date: 2025-04-14 (Mon, 14 Apr 2025)
Changed paths:
A LayoutTests/storage/indexeddb/delete-indexes-with-same-name-expected.txt
A
LayoutTests/storage/indexeddb/delete-indexes-with-same-name-private-expected.txt
A LayoutTests/storage/indexeddb/delete-indexes-with-same-name-private.html
A LayoutTests/storage/indexeddb/delete-indexes-with-same-name.html
A LayoutTests/storage/indexeddb/resources/delete-indexes-with-same-name.js
M Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.h
Log Message:
-----------
MemoryBackingStoreTransaction::m_deletedIndexes should not track indexes by
name
rdar://141931985
Reviewed by Chris Dumez.
According to spec
(https://www.w3.org/TR/IndexedDB/#dom-idbobjectstore-createindex), index name
is unique in its object
store. A transaction can operate on multiple object stores, so index name is
not unique in transaction, and transaction
should not track indexes by name. To fix this, make
MemoryBackingStoreTransaction::m_deletedIndexes a set instead of
a map.
Tests: storage/indexeddb/delete-indexes-with-same-name.html
storage/indexeddb/delete-indexes-with-same-name-private.html
* LayoutTests/storage/indexeddb/delete-indexes-with-same-name-expected.txt:
Added.
*
LayoutTests/storage/indexeddb/delete-indexes-with-same-name-private-expected.txt:
Added.
* LayoutTests/storage/indexeddb/delete-indexes-with-same-name-private.html:
Added.
* LayoutTests/storage/indexeddb/delete-indexes-with-same-name.html: Added.
* LayoutTests/storage/indexeddb/resources/delete-indexes-with-same-name.js:
Added.
(prepareDatabase):
(upgradeDatabase):
(deleteIndexes):
* Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::indexDeleted):
(WebCore::IDBServer::MemoryBackingStoreTransaction::objectStoreDeleted):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
* Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
Originally-landed-as: 283286.616@safari-7620-branch (7ffc1f92efb2).
rdar://148116461
Canonical link: https://commits.webkit.org/293685@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
