Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2c0038e9d995133c2b0830f4a2f5ec8e33fda355
https://github.com/WebKit/WebKit/commit/2c0038e9d995133c2b0830f4a2f5ec8e33fda355
Author: Chris Dumez <[email protected]>
Date: 2025-04-16 (Wed, 16 Apr 2025)
Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WTF/wtf/UnalignedAccess.h
Log Message:
-----------
REGRESSION (288265@main): [ macOS wk1 debug ]
inspector/console/console-oom.html is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=291598
rdar://149340500
Reviewed by Ryosuke Niwa.
The changes to UnalignedAccess.h made in 288265@main made the test runtime go
from
30-50s to ~175s in debug builds (no ovbious regression on release builds but the
runtime is much shorter there 2-3s).
Given that these functions in UnalignedAccess.h currently take a raw `void*`
pointer
and no size, using memcpySpan() instead of memcpy() doesn't actually improve
safety
here. I am therefore reverting the changes I made to UnalignedAccess.h.
It appears a lot of the CPY cycles were spent under `unsafeMakeSpan()`.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WTF/wtf/UnalignedAccess.h:
(WTF::unalignedLoad):
(WTF::unalignedStore):
Canonical link: https://commits.webkit.org/293754@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
