Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bbe2bab9e62bf03df2e7d15b108d4ce3a1089ade
https://github.com/WebKit/WebKit/commit/bbe2bab9e62bf03df2e7d15b108d4ce3a1089ade
Author: Georges Basile Stavracas Neto <[email protected]>
Date: 2025-04-16 (Wed, 16 Apr 2025)
Changed paths:
M Source/WebKit/Shared/wpe/WebEventFactoryWPE.cpp
M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp
Log Message:
-----------
[WPE] Drag gesture is overscrolling
https://bugs.webkit.org/show_bug.cgi?id=291562
Reviewed by Patrick Griffis.
The wpeScrollDeltaMultiplier constant tries to mimic GTK's own
MAGIC_SCROLL_FACTOR value from GtkScrolledWindow. However, GTK
only applies this factor for touchpad and mouse scroll events,
whereas WPE applies it to everything - including touch drag
events. This leads to drag gestures overscrolling.
Fix that by differentiating the wpeScrollDeltaMultiplier value
between gestures and non-gestures. For gestures, neutralize it
to 1.0; for non-gestures, keep the current value of 2.5.
This is done by changing the input source type of the synthetic
scroll event to WPE_INPUT_SOURCE_TOUCHSCREEN. This is then used
by WebEventFactory::createWebWheelEvent() to select the correct
scroll factor.
* Source/WebKit/Shared/NativeWebWheelEvent.h:
* Source/WebKit/Shared/libwpe/WebEventFactory.h:
* Source/WebKit/Shared/wpe/NativeWebWheelEventWPE.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
* Source/WebKit/Shared/wpe/WebEventFactoryWPE.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
* Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp:
(WKWPE::ViewPlatform::handleGesture):
Canonical link: https://commits.webkit.org/293775@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
