Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa4f2dec9d0dff9be59f44c669cd874b6b7e0954
      
https://github.com/WebKit/WebKit/commit/fa4f2dec9d0dff9be59f44c669cd874b6b7e0954
  Author: Rob Buis <[email protected]>
  Date:   2025-04-17 (Thu, 17 Apr 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid.html
    M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp

  Log Message:
  -----------
  CSSStyleValue.parseAll with empty value should not hit ASSERT
https://bugs.webkit.org/show_bug.cgi?id=291676

Reviewed by Anne van Kesteren.

In Debug the handling of empty CSS values can cause ASSERTs to be hit, early 
exit for this
case in CSSStyleValueFactory::parseStyleValue. Also add a subtest to 
parseAll-invalid.html to verify no ASSERT
is hit anymore.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid.html:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::extractCustomCSSValues):
(WebCore::CSSStyleValueFactory::parseStyleValue):

Canonical link: https://commits.webkit.org/293846@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to