Title: [112573] trunk/Source/WebCore
Revision
112573
Author
[email protected]
Date
2012-03-29 13:57:37 -0700 (Thu, 29 Mar 2012)

Log Message

Images that reload via media queries don't paint when device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=82648
<rdar://problem/11143637>

Reviewed by Beth Dakin.

Commit scale factor changes before dirty rect changes, since setting the scale factor
can lead to more rects being dirtied when using the tile cache.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (112572 => 112573)


--- trunk/Source/WebCore/ChangeLog	2012-03-29 20:52:48 UTC (rev 112572)
+++ trunk/Source/WebCore/ChangeLog	2012-03-29 20:57:37 UTC (rev 112573)
@@ -1,3 +1,17 @@
+2012-03-29  Anders Carlsson  <[email protected]>
+
+        Images that reload via media queries don't paint when device scale factor changes
+        https://bugs.webkit.org/show_bug.cgi?id=82648
+        <rdar://problem/11143637>
+
+        Reviewed by Beth Dakin.
+
+        Commit scale factor changes before dirty rect changes, since setting the scale factor
+        can lead to more rects being dirtied when using the tile cache.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
+
 2012-03-29  Adam Barth  <[email protected]>
 
         Move CPP files related to ResourceHandle to WebCore/platform

Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (112572 => 112573)


--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2012-03-29 20:52:48 UTC (rev 112572)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2012-03-29 20:57:37 UTC (rev 112573)
@@ -1041,7 +1041,12 @@
     
     if (m_uncommittedChanges & AnimationChanged)
         updateLayerAnimations();
-    
+
+    // Updating the contents scale can cause parts of the layer to be invalidated,
+    // so make sure to update the contents scale before updating the dirty rects.
+    if (m_uncommittedChanges & ContentsScaleChanged)
+        updateContentsScale(pageScaleFactor, positionRelativeToBase);
+
     if (m_uncommittedChanges & DirtyRectsChanged)
         repaintLayerDirtyRects();
     
@@ -1056,9 +1061,6 @@
     
     if (m_uncommittedChanges & AcceleratesDrawingChanged)
         updateAcceleratesDrawing();
-    
-    if (m_uncommittedChanges & ContentsScaleChanged)
-        updateContentsScale(pageScaleFactor, positionRelativeToBase);
 }
 
 void GraphicsLayerCA::commitLayerChangesAfterSublayers()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to