Title: [112580] trunk/Tools
- Revision
- 112580
- Author
- [email protected]
- Date
- 2012-03-29 14:48:38 -0700 (Thu, 29 Mar 2012)
Log Message
Scripts fail to detect when a tool crashes
https://bugs.webkit.org/show_bug.cgi?id=82659
Reviewed by Mark Rowe.
Have exitStatus() detect when the process fail to exit cleanly
(possibly because of a crash), and return a non-zero exit code
in that case.
* Scripts/VCSUtils.pm:
(exitStatus):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (112579 => 112580)
--- trunk/Tools/ChangeLog 2012-03-29 21:44:28 UTC (rev 112579)
+++ trunk/Tools/ChangeLog 2012-03-29 21:48:38 UTC (rev 112580)
@@ -1,3 +1,17 @@
+2012-03-29 Simon Fraser <[email protected]>
+
+ Scripts fail to detect when a tool crashes
+ https://bugs.webkit.org/show_bug.cgi?id=82659
+
+ Reviewed by Mark Rowe.
+
+ Have exitStatus() detect when the process fail to exit cleanly
+ (possibly because of a crash), and return a non-zero exit code
+ in that case.
+
+ * Scripts/VCSUtils.pm:
+ (exitStatus):
+
2012-03-29 Dominik Röttsches <[email protected]>
[GTK][EFL] run-_javascript_core-tests should be run through jhbuild
Modified: trunk/Tools/Scripts/VCSUtils.pm (112579 => 112580)
--- trunk/Tools/Scripts/VCSUtils.pm 2012-03-29 21:44:28 UTC (rev 112579)
+++ trunk/Tools/Scripts/VCSUtils.pm 2012-03-29 21:48:38 UTC (rev 112580)
@@ -120,6 +120,9 @@
if ($^O eq "MSWin32") {
return $returnvalue >> 8;
}
+ if (!WIFEXITED($returnvalue)) {
+ return 254;
+ }
return WEXITSTATUS($returnvalue);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
