Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 13ba825e9fdb925286196161cf3e9e78190c4bcd
https://github.com/WebKit/WebKit/commit/13ba825e9fdb925286196161cf3e9e78190c4bcd
Author: Brian Weinstein <bweinst...@apple.com>
Date: 2025-04-22 (Tue, 22 Apr 2025)
Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionCommand.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionCommand.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionContext.mm
Log Message:
-----------
WebExtensionCommand::setActivationKey should generate an upper case
activation key on iOS
https://bugs.webkit.org/show_bug.cgi?id=291858
rdar://149522241
Reviewed by Timothy Hatcher.
This matches the platform standard on iOS. On macOS, if the activation key is a
capital letter,
that is considered an implicit shift modifier. However, that is not the case on
iOS, and the platform
standard is to specify a capital letter as the UIKeyCommand's input.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm:
(WebKit::WebExtensionCommand::setActivationKey):
* Source/WebKit/UIProcess/Extensions/WebExtensionCommand.cpp:
(WebKit::WebExtensionCommand::WebExtensionCommand):
* Source/WebKit/UIProcess/Extensions/WebExtensionCommand.h:
Canonical link: https://commits.webkit.org/293959@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
