Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ffe4818ea49d7bcb19eb8f1a058f0f3060349f6b
https://github.com/WebKit/WebKit/commit/ffe4818ea49d7bcb19eb8f1a058f0f3060349f6b
Author: Aditya Keerthi <[email protected]>
Date: 2025-04-23 (Wed, 23 Apr 2025)
Changed paths:
M Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
Log Message:
-----------
[macOS][Writing Tools] Text cut off after second Rewrite animation following
a window resize
https://bugs.webkit.org/show_bug.cgi?id=291880
rdar://149435144
Reviewed by Abrar Rahman Protyasha.
`_WTTextEffectView`'s frame is currently only set once, when
`WKTextAnimationManager`
is initialized, upon the first text animation.
Consequently, if the window is resized, subsequent animations are performed with
an incorrect text effect view frame. If the window size is increased, this
results
in cut off text during the animation.
Fix by updating the frame of the effect view whenever the initial animation
begins.
This matches iOS, which updates the frame of the effect view when the
"placeholder"
animation begins.
* Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm:
(-[WKTextAnimationManager addTextAnimationForAnimationID:withData:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, CompositionAnimationSizing)):
Canonical link: https://commits.webkit.org/294009@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
