Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d053cfaee75dac29ebff28a03f0a99d05709457
      
https://github.com/WebKit/WebKit/commit/5d053cfaee75dac29ebff28a03f0a99d05709457
  Author: Alan Baradlay <[email protected]>
  Date:   2025-04-23 (Wed, 23 Apr 2025)

  Changed paths:
    M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h
    M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h

  Log Message:
  -----------
  [IFC] Do not try to paint/hittest damaged inline content
https://bugs.webkit.org/show_bug.cgi?id=291927

Reviewed by Antti Koivisto.

Layout is expected to clear all the damaged renderer. Should that not happen, 
we may
end up trying to paint/hittest damaged inline content. Such inline content
may contain (weak) references to already destroyed renderers.

Let's check if we are in this unexpected state and bail out early.

* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h:
(WebCore::Layout::InlineDamage::hasDetachedContent const):
* 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
(WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox):
(WebCore::LayoutIntegration::InlineContentPainter::paint):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::isContentConsideredStale const):
(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::hitTest):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:

Canonical link: https://commits.webkit.org/294019@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to