Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2b92fbecf3598729dbc46c29ff7381e88aef8d4a
https://github.com/WebKit/WebKit/commit/2b92fbecf3598729dbc46c29ff7381e88aef8d4a
Author: Jer Noble <[email protected]>
Date: 2025-04-25 (Fri, 25 Apr 2025)
Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/platform/audio/cocoa/SpatialAudioExperienceHelper.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
Log Message:
-----------
[visionOS] Audio from window B is located in window A when switching tabs
rdar://149700482
https://bugs.webkit.org/show_bug.cgi?id=292017
Reviewed by Eric Carlson.
HTMLMediaElement was not setting the correct, initial scene identifier when
creating a new
MediaPlayer; the scene identifier would only be sent to the MediaPlayer when it
changed.
Drive-by fixes:
- At the suggestion of the visionOS audio team, use an automatic anchoring
strategy with a
head-tracked experience when the scene identifier is not present.
- Remove a duplicate `updateSpatialTrackingLabel()` call from
MediaPlayerPrivateAVFoundationObjC::createAVPlayer().
- Increase the log level for spatial experience changes from Info -> Always.
* Source/WebCore/html/HTMLMediaElement.cpp:
* Source/WebCore/platform/audio/cocoa/SpatialAudioExperienceHelper.mm:
(WebCore::createSpatialAudioExperienceWithOptions):
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateSpatialTrackingLabel):
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateSpatialTrackingLabel):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SpatialAudioExperience.mm: Added.
(-[SpatialAudioExperienceLoggingDelegate
_webView:logDiagnosticMessage:description:valueDictionary:]):
(autoplayingConfiguration):
(TEST(SpatialAudioExperience, Basic)):
Canonical link: https://commits.webkit.org/294112@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
