Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 983a998e43efcc39ca03b7fb47cd150870091b1c
      
https://github.com/WebKit/WebKit/commit/983a998e43efcc39ca03b7fb47cd150870091b1c
  Author: Sihui Liu <[email protected]>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M Source/WebCore/platform/network/NetworkStorageSession.cpp
    M Source/WebCore/platform/network/NetworkStorageSession.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm

  Log Message:
  -----------
  Avoid resuming task if session is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=292034
rdar://149775419

Reviewed by Per Arne Vollan.

In existing implementation, CookieVersionChangeCallback can be invoked when 
session is destroyed; in this case, we
should not resume network data task, otherwise it might access the session and 
crash.

* Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::setCookiesVersion):
(WebCore::NetworkStorageSession::addCookiesVersionChangeCallback):
(WebCore::NetworkStorageSession::clearCookiesVersionChangeCallbacks):
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::resume):

Canonical link: https://commits.webkit.org/294115@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to