Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24929a7d9dcc0eaa8d8e9cdea6e5b2371bfe2d73 https://github.com/WebKit/WebKit/commit/24929a7d9dcc0eaa8d8e9cdea6e5b2371bfe2d73 Author: Sam Weinig <s...@webkit.org> Date: 2025-04-26 (Sat, 26 Apr 2025)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-x-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-x-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-y-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-y-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-valid.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-computed.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-computed.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-invalid.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-invalid.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-valid.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-valid.tentative.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.cpp M Source/WebCore/css/values/primitives/CSSPosition.h M Source/WebCore/style/values/primitives/StylePosition.cpp Log Message: ----------- Add support for axis relative keywords to for <position> https://bugs.webkit.org/show_bug.cgi?id=292069 Reviewed by Darin Adler. Adds support for the axis relative keywords for <position> and <bg-position> including: - x-start - x-end - y-start - y-end These are all resolved at style building time, so only the CSS specified value representation, parsing and style conversion needed updating. Enabled behind a preference flag CSSAxisRelativePositionKeywordsEnabled. * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-x-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-x-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-y-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-y-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-valid.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-computed.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-computed.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-invalid.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-invalid.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-valid.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/position/position-valid.tentative.html: Added. - Add and update tests. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: - Add new preference flag CSSAxisRelativePositionKeywordsEnabled that the new functionality is behind. * Source/WebCore/css/parser/CSSParserContext.cpp: * Source/WebCore/css/parser/CSSParserContext.h: - Pipe the preferences flag to the parser context for use by the parser. * Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.cpp: - Support parsing the new forms. * Source/WebCore/css/values/primitives/CSSPosition.h: - Support representing the new forms. * Source/WebCore/style/values/primitives/StylePosition.cpp: - Support resolving the new forms. Canonical link: https://commits.webkit.org/294158@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes