Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1177dcf7f087d0abfe193bdf3d94ddb07ce6d2dd
https://github.com/WebKit/WebKit/commit/1177dcf7f087d0abfe193bdf3d94ddb07ce6d2dd
Author: Philippe Normand <ph...@igalia.com>
Date: 2025-04-28 (Mon, 28 Apr 2025)
Changed paths:
M
Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp
M
Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h
Log Message:
-----------
[GStreamer][MediaStream] Crash on
https://mozilla.github.io/webrtc-landing/gum_test.html
https://bugs.webkit.org/show_bug.cgi?id=291837
Reviewed by Xabier Rodriguez-Calvar.
The crash was happening due to a division by zero, the intrinsic size being set
to 0x0. By
implementing applyFrameRateAndZoomWithPreset() the intrinsic size is now set
and the framerate
applied to the capturer, although desktop capture currently doesn't support
this, but that's a
separate issue.
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::settingsDidChange):
(WebCore::GStreamerVideoCaptureSource::sourceCapsChanged):
(WebCore::GStreamerVideoCaptureSource::generatePresets):
(WebCore::GStreamerVideoCaptureSource::applyFrameRateAndZoomWithPreset):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
Canonical link: https://commits.webkit.org/294171@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
