Branch: refs/heads/webkitglib/2.48
Home: https://github.com/WebKit/WebKit
Commit: 532ab23dc82d17244b4d8dfd7b84a7f5f2ee533f
https://github.com/WebKit/WebKit/commit/532ab23dc82d17244b4d8dfd7b84a7f5f2ee533f
Author: Enrique Ocaña González <[email protected]>
Date: 2025-04-28 (Mon, 28 Apr 2025)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Log Message:
-----------
Cherry-pick 293459@main (29aaf6c0d8ef).
https://bugs.webkit.org/show_bug.cgi?id=291277
[GStreamer] triggerRepaint() should allow a null previousBuffer
https://bugs.webkit.org/show_bug.cgi?id=291277
Reviewed by Philippe Normand.
We're getting some crashes downstream in
https://ytlr-cert.appspot.com/2021/main.html?&test_type=progressive-test&command=run
on Raspberry Pi, and they're caused by RELEASE_ASSERT(previousBuffer) in
MediaPlayerPrivateGStreamer::triggerRepaint(). When debugged, I
realized that the null previousBuffer was set by gst_buffer_copy_deep()
in MediaPlayerPrivateGStreamer::flushCurrentBuffer(). This means that
the deep copy failed to produce a valid buffer. This is sort of expected
in Raspberry Pi when using the OMX decoder, since those buffers come
from a special buffer pool managed by OMX and reference scarce GPU
memory (caps: video/x-raw(memory:GLMemory)).
This patch removes the assert and adds an extra log line to make future
developers debugging issues aware of the fact that null buffers are
being used now and why.
*
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::triggerRepaint): Remove assert.
(WebCore::MediaPlayerPrivateGStreamer::flushCurrentBuffer): Warn that the
buffer couldn't be copied, if that's the case.
Canonical link: https://commits.webkit.org/293459@main
Canonical link: https://commits.webkit.org/290945.167@webkitglib/2.48
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
