Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cf812ebb0763340bbdd54dd68e1c2a7c05f2146
      
https://github.com/WebKit/WebKit/commit/9cf812ebb0763340bbdd54dd68e1c2a7c05f2146
  Author: Alan Baradlay <[email protected]>
  Date:   2025-04-30 (Wed, 30 Apr 2025)

  Changed paths:
    A 
LayoutTests/fast/repaint/inline-flex-color-changes-fail-repaint-expected.txt
    A LayoutTests/fast/repaint/inline-flex-color-changes-fail-repaint.html
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  `text-decoration-color` transition omitted on `inline-flex` elements
https://bugs.webkit.org/show_bug.cgi?id=292078
<rdar://problem/150367425>

Reviewed by Antti Koivisto.

StyleDifference::RepaintIfText tells us to repaint the renderer only if it has 
text content.
This works as long as we don't have to wrap the text content inside an 
anonymous block container. So while in the example below

<div style="display: inline-flex">text</div>

while 'text' is a direct child of the inline-flex container, after tree 
normalization it
becomes a child of an anonymous block container representing the block level 
flex item.

This change ensures that when the incoming diff is RepaintIfText paint 
invalidation happens even
when the text content is not a direct child.

* LayoutTests/fast/repaint/inline-flex-color-changes-fail-repaint-expected.txt: 
Added.
* LayoutTests/fast/repaint/inline-flex-color-changes-fail-repaint.html: Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::shouldRepaintForStyleDifference const):

Canonical link: https://commits.webkit.org/294358@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to