Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 44423b0ba8e1a667cd94d670c47ef7fae2608b17
https://github.com/WebKit/WebKit/commit/44423b0ba8e1a667cd94d670c47ef7fae2608b17
Author: Richard Robinson <[email protected]>
Date: 2025-05-01 (Thu, 01 May 2025)
Changed paths:
M
Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
Log Message:
-----------
[Writing Tools] Several Writing Tools tests are failing
https://bugs.webkit.org/show_bug.cgi?id=292379
rdar://150453007
Reviewed by Aditya Keerthi.
Fix various tests; see per-function explanation below.
*
Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift:
Remove an assertion that was wrong, since it is perfectly valid for a preview
to not generate,
such as when the range is empty.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, APIWithBehaviorDefault)):
(TEST(WritingTools, APIWithBehaviorComplete)):
(TEST(WritingTools, ShowAffordance)):
(TEST(WritingTools, ShowAffordanceForMultipleLines)):
(TEST(WritingTools, ShowPanelWithNoSelection)):
(TEST(WritingTools, ShowPanelWithCaretSelection)):
(TEST(WritingTools, ShowPanelWithRangedSelection)):
These tests weren't failing, they just were not running. Get these tests to run
properly by just
swizzling WT availability to pretend it's available.
(TEST(WritingTools, ShowToolWithRangedSelection)):
(TEST(WritingTools, ShowInvalidToolWithRangedSelection)):
(TEST(WritingTools, ContextMenuItemsNonEditable)):
(TEST(WritingTools, ContextMenuItemsEditable)):
(TEST(WritingTools, ContextMenuItemsEditableEmpty)):
These tests were failing for the same reasons, but just never had the guard in
place.
(TEST(WritingTools, FocusWebViewAfterAnimation)):
This test was flakily failing due to the length of the animation, so expand the
hard-coded delay.
(TEST(WritingTools, CompositionAnimationSizing)):
Ditto.
(TEST(WritingTools,
IntelligenceTextEffectCoordinatorDelegate_RectsForProofreadingSuggestionsInRange)):
This was originally passing on macOS and failing on iOS. 294371@main made it
pass on iOS, but accidentally
made it fail on macOS. Make it work on both platforms by just having specific
expectations for each, which
is precedent from other API tests.
Canonical link: https://commits.webkit.org/294377@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
