Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa2299902e28fe0f8d84e1bb59c826993f458c2d
      
https://github.com/WebKit/WebKit/commit/fa2299902e28fe0f8d84e1bb59c826993f458c2d
  Author: Richard Robinson <richard_robins...@apple.com>
  Date:   2025-05-01 (Thu, 01 May 2025)

  Changed paths:
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
    M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  [Writing Tools] Support compiling ENABLE_WRITING_TOOLS on the public SDK 
(Part 6)
https://bugs.webkit.org/show_bug.cgi?id=291851
rdar://149695687

Reviewed by Aditya Keerthi.

The final piece of the puzzle.

Compiling ENABLE_WRITING_TOOLS on the public SDK reveals some pre-existing 
Safer CPP failures.
Prepare for the enablement by adding expectations to the affected files, which 
will be fixed in
a subsequent PR.

Now that all other issues are resolved, actually start compiling 
ENABLE_WRITING_TOOLS on the public SDK!

* Source/WTF/wtf/PlatformEnableCocoa.h:

Enable the flag on the public SDK!

* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:

Add expectations to reflect the existing failures.

* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuTarget showWritingTools:]):
(WebKit::WebContextMenuProxyMac::handleContextMenuWritingTools):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::addTextAnimationForAnimationID):
(WebKit::WebViewImpl::removeTextAnimationForAnimationID):

Fix some trivial Safer CPP issues.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelection):

Fix some trivial Safer CPP issues, and remove an UNUSED_PARAM that isn't needed.

Canonical link: https://commits.webkit.org/294399@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to