Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 97a032c9d8502c4c3250642ac7031785767b6085
https://github.com/WebKit/WebKit/commit/97a032c9d8502c4c3250642ac7031785767b6085
Author: Philippe Normand <[email protected]>
Date: 2025-05-02 (Fri, 02 May 2025)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
Log Message:
-----------
[GStreamer][1.26] Critical warnings in volume element
https://bugs.webkit.org/show_bug.cgi?id=290537
Reviewed by Xabier Rodriguez-Calvar.
The seeks performed by oggdemux to determine the stream duration led our http
source element to an
inconsistent state where haveSize was set to false and size to a valid value,
so the
webKitWebSrcGetSize() call was failing even though we had a valid size. By
removing haveSize and
changing size to an optional<uint64_t> the code is now less error-prone and
easier to follow.
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkitWebSrcReset):
(restartLoaderIfNeeded):
(stopLoaderIfNeeded):
(webKitWebSrcCreate):
(webKitWebSrcGetSize):
(webKitWebSrcDoSeek):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::recalculateLengthAndSeekableIfNeeded):
(CachedResourceStreamingClient::dataReceived):
Canonical link: https://commits.webkit.org/294419@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
