Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 93524d44866405408cc350115d87c4b5fdfcaa4c
https://github.com/WebKit/WebKit/commit/93524d44866405408cc350115d87c4b5fdfcaa4c
Author: Brianna Fan <[email protected]>
Date: 2025-05-02 (Fri, 02 May 2025)
Changed paths:
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py
M
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py
Log Message:
-----------
git webkit appears to be incorrectly using the first radar link in bugzilla
instead of the last one
https://bugs.webkit.org/show_bug.cgi?id=292230
rdar://149093470
Reviewed by Sam Sneddon and Jonathan Bedard.
We should prioritize bugs commented more recently, as they are likely
corrections. Using the first link or
prioritizing the bug importer over a human comment would be incorrect in that
case.
To match WKBI, we only match bugs at the start of a line.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.populate): Reverse the comments and remove preference for the bug
importer.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py:
(TestBugzilla.test_reference_order): Add test for ordering.
(TestBugzilla.test_reference_parse):
(TestBugzilla.test_reference_multiline):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py:
(TestRadar.test_reference_parse):
(TestRadar.test_reference_multiline):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py:
(Tracker): Update REFERENCE_RE to only look for bugs at the start of a line.
Canonical link: https://commits.webkit.org/294444@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
