Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 98548924f48f6e5eb83ca120f38b8bcbe720c580
https://github.com/WebKit/WebKit/commit/98548924f48f6e5eb83ca120f38b8bcbe720c580
Author: Tyler Wilcock <[email protected]>
Date: 2025-05-02 (Fri, 02 May 2025)
Changed paths:
A LayoutTests/accessibility/mac/invalid-list-box-expected.txt
A LayoutTests/accessibility/mac/invalid-list-box.html
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Log Message:
-----------
AX: To avoid confusing ATs, WebKit should avoid exposing listboxes as
listboxes if they don't have any option descendants
https://bugs.webkit.org/show_bug.cgi?id=292443
rdar://150533266
Reviewed by Joshua Hoffman.
If a role="listbox" has no options, we should just call it a group to avoid
confusing assistive technologies who expect
listboxes to have a certain structure. Said confusion can have adverse side
effects, like VoiceOver failing to navigate
content within an invalid listbox.
This commit also removes unused AXProperty::IsListBox.
* LayoutTests/accessibility/mac/invalid-list-box-expected.txt: Added.
* LayoutTests/accessibility/mac/invalid-list-box.html: Added.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isValidListBox const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::isInvalidListBox const):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::AXCoreObject::rolePlatformString):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/294459@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
