Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a293216b4744c279c10e6c93c52307c10bce484
https://github.com/WebKit/WebKit/commit/9a293216b4744c279c10e6c93c52307c10bce484
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-05-02 (Fri, 02 May 2025)
Changed paths:
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Modules/Internal/WebKitInternal.h
M Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.h
M Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
[UnifiedPDF] PDFPageNumberIndicator cannot use UIVisualEffectView in all
configurations
https://bugs.webkit.org/show_bug.cgi?id=292454
rdar://149981713
Reviewed by Aditya Keerthi and Richard Robinson.
UIVisualEffectView is not appropriate for the backdrop of the page
number indicator under certain platform configurations. In such cases,
this patch introduces a path to fallback to a generic UIView that has
its background appropriately configured to not regress the indicator's
functionality.
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Modules/Internal/WebKitInternal.h:
* Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.h:
* Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.mm:
(-[WKPDFPageNumberIndicator initWithFrame:view:pageCount:]):
Note that when the backdrop is not a UIVisualEffectView, we must take
care to add the page number label directly to the backdrop view, and not
to the `contentView` under the backdrop.
(-[WKPDFPageNumberIndicator backdropView]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/294462@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
