Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 37ba9b0bea2a73a54a97e2e88fec24ba6f93bc7b
https://github.com/WebKit/WebKit/commit/37ba9b0bea2a73a54a97e2e88fec24ba6f93bc7b
Author: Ada Chan <[email protected]>
Date: 2025-05-05 (Mon, 05 May 2025)
Changed paths:
M Source/WebCore/Modules/model-element/ModelPlayer.cpp
M Source/WebCore/Modules/model-element/ModelPlayer.h
A Source/WebCore/Modules/model-element/ModelPlayerTransformState.h
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/Sources.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
A Source/WebKit/WebProcess/Model/ModelProcessModelPlayerTransformState.cpp
A Source/WebKit/WebProcess/Model/ModelProcessModelPlayerTransformState.h
M Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp
Log Message:
-----------
Introduce ModelPlayerTransformState protocol that contains info about the
model's bounds and transform
https://bugs.webkit.org/show_bug.cgi?id=292506
rdar://150614639
Reviewed by Mike Wyrzykowski.
Introduce ModelProcessModelPlayerTransformState that implements
ModelPlayerTransformState.
The logic to determine whether a transform matrix is supported is moved from
ModelProcessModelPlayerProxy to there, so it can be used in
ModelProcessModelPlayerTransformState::isEntityTransformSupported() also.
Add a new method in ModelPlayer for getting the current transform state.
Implement this method in ModelProcessModelPlayer. This will be used in a
later patch for restoring the ModelPlayer state after reload.
* Source/WebCore/Modules/model-element/ModelPlayer.cpp:
(WebCore::ModelPlayer::currentTransformState const):
(WebCore::ModelPlayer::boundingBoxCenter const):
(WebCore::ModelPlayer::boundingBoxExtents const):
(WebCore::ModelPlayer::entityTransform const):
* Source/WebCore/Modules/model-element/ModelPlayer.h:
* Source/WebCore/Modules/model-element/ModelPlayerTransformState.h: Added.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::areSameSignAndAlmostEqual): Deleted.
(WebKit::ModelProcessModelPlayerProxy::transformSupported): Deleted.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::didFinishLoading):
(WebKit::ModelProcessModelPlayer::didUpdateEntityTransform):
(WebKit::ModelProcessModelPlayer::currentTransformState const):
(WebKit::ModelProcessModelPlayer::boundingBoxCenter const):
(WebKit::ModelProcessModelPlayer::boundingBoxExtents const):
(WebKit::ModelProcessModelPlayer::entityTransform const):
(WebKit::ModelProcessModelPlayer::setEntityTransform):
(WebKit::ModelProcessModelPlayer::supportsTransform):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayerTransformState.cpp:
Added.
(WebKit::ModelProcessModelPlayerTransformState::create):
(WebKit::ModelProcessModelPlayerTransformState::ModelProcessModelPlayerTransformState):
(WebKit::areSameSignAndAlmostEqual):
(WebKit::ModelProcessModelPlayerTransformState::transformSupported):
(WebKit::ModelProcessModelPlayerTransformState::setEntityTransform):
(WebKit::ModelProcessModelPlayerTransformState::isEntityTransformSupported
const):
(WebKit::ModelProcessModelPlayerTransformState::setHasPortal):
(WebKit::ModelProcessModelPlayerTransformState::setStageMode):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayerTransformState.h: Added.
* Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
Canonical link: https://commits.webkit.org/294513@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes