Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 93f03ffffb803aebc218be3fb210db9672bc99a2
https://github.com/WebKit/WebKit/commit/93f03ffffb803aebc218be3fb210db9672bc99a2
Author: Antti Koivisto <[email protected]>
Date: 2025-05-06 (Tue, 06 May 2025)
Changed paths:
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp
M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h
M Source/WebCore/rendering/ios/RenderThemeIOS.h
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
M Source/WebCore/rendering/mac/RenderThemeMac.h
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebCore/style/MatchResultCache.cpp
M Source/WebCore/style/MatchedDeclarationsCache.cpp
M Source/WebCore/style/MatchedDeclarationsCache.h
M Source/WebCore/style/ResolvedStyle.h
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/style/StyleAdjuster.h
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilderState.cpp
M Source/WebCore/style/StyleBuilderState.h
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
Log Message:
-----------
Remove userAgentAppearanceStyle
https://bugs.webkit.org/show_bug.cgi?id=286288
rdar://143305321
Reviewed by Aditya Keerthi.
We now track in style builder if author mutated border or background properties
that disable
native control styling. Checking for this is the only reason we generate and
cache this style.
The userAgentAppearanceStyle is already unused and maintained unnecessarily
when "devolved widget"
feature is enabled (which it is by default). This patch aligns the legacy case
with the standard too
by having any author mutation to border and background style disable the native
appearance
(rather than requiring it to bet set to something that differs from UA style).
The legacy list of
affected controls is maintained.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::hasAppearanceForElementTypeFromUAStyle):
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::isControlStyled const):
* Source/WebCore/rendering/RenderTheme.h:
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::isControlStyled const):
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h:
* Source/WebCore/rendering/ios/RenderThemeIOS.h:
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::isControlStyled const):
* Source/WebCore/rendering/mac/RenderThemeMac.h:
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::isControlStyled const):
* Source/WebCore/style/MatchResultCache.cpp:
(WebCore::Style::copy):
* Source/WebCore/style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::add):
* Source/WebCore/style/MatchedDeclarationsCache.h:
* Source/WebCore/style/ResolvedStyle.h:
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
(WebCore::Style::Adjuster::adjustAnimatedStyle const):
(WebCore::Style::Adjuster::adjustThemeStyle const):
* Source/WebCore/style/StyleAdjuster.h:
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::applyProperty):
* Source/WebCore/style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::disableNativeAppearanceIfNeeded):
Factor into a function in BuilderState.
Set the nativeAppearanceDisabled bit also in the legacy
hasAppearanceForElementTypeFromUAStyle case.
* Source/WebCore/style/StyleBuilderState.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::State::takeStyle):
(WebCore::Style::Resolver::unadjustedStyleForElement):
(WebCore::Style::Resolver::styleForElement):
(WebCore::Style::Resolver::unadjustedStyleForCachedMatchResult):
(WebCore::Style::Resolver::styleForKeyframe):
(WebCore::Style::Resolver::styleForPseudoElement):
(WebCore::Style::Resolver::applyMatchedProperties):
(WebCore::Style::Resolver::State::takeUserAgentAppearanceStyle): Deleted.
(WebCore::Style::Resolver::State::userAgentAppearanceStyle const): Deleted.
(WebCore::Style::Resolver::State::setUserAgentAppearanceStyle): Deleted.
(WebCore::Style::elementTypeHasAppearanceFromUAStyle): Deleted.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::styleForStyleable):
(WebCore::Style::TreeResolver::resolveAgainInDifferentContext):
Canonical link: https://commits.webkit.org/294554@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
