Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 01aabfa3d78335deafdd34e69d1d59d03d636f59
https://github.com/WebKit/WebKit/commit/01aabfa3d78335deafdd34e69d1d59d03d636f59
Author: Elliott Williams <[email protected]>
Date: 2025-05-06 (Tue, 06 May 2025)
Changed paths:
M Source/WebInspectorUI/Configurations/Base.xcconfig
M Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
M Tools/TestWebKitAPI/Configurations/Base.xcconfig
M Tools/TestWebKitAPI/Configurations/TestWebKitAPIBase.xcconfig
M Tools/WebKitTestRunner/Configurations/Base.xcconfig
Log Message:
-----------
[Xcode] Some targets accessing /System/Library/PrivateFrameworks through
non-system include paths
https://bugs.webkit.org/show_bug.cgi?id=292451
rdar://150539568
Reviewed by Alexey Proskuryakov.
Fix a few instances of configurations like this:
FRAMEWORK_SEARCH_PATHS = $(inherited)
$(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR)
$(SDK_DIR)$(NORMAL_UMBRELLA_FRAMEWORKS_DIR);
AFAICT, the intention here is to give the compiler access staged WebKit
frameworks in downlevel builds, plus WebCore and WebKitLegacy inside the
WebKit.framework umbrella. But on embedded platforms, there is no WebKit
umbrella and NORMAL_UMBRELLA_FRAMEWORKS_DIR is just
/System/Library/PrivateFrameworks.
Regardless, even when these build settings refer only to WebKit
frameworks, they should be on the system path. Test tools should not
fail due to diagnostics in WebKit headers.
Along the way, move $(inherited) to the front of the list in these
settings, to align with all other projects.
* Source/WebInspectorUI/Configurations/Base.xcconfig:
* Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPIBase.xcconfig: Also
move SYSTEM_FRAMEWORK_SEARCH_PATHS to a better location in the file.
* Tools/WebKitTestRunner/Configurations/Base.xcconfig: Somehow this
project was building without referencing WK_PRIVATE_SDK_DIR. Add it.
Canonical link: https://commits.webkit.org/294568@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
