Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 48f94876ce2f2aa91bdbc15afbd8672bbfd509b4
https://github.com/WebKit/WebKit/commit/48f94876ce2f2aa91bdbc15afbd8672bbfd509b4
Author: Kimmo Kinnunen <[email protected]>
Date: 2025-05-07 (Wed, 07 May 2025)
Changed paths:
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorInlines.h
M Source/WebCore/html/ColorInputType.cpp
M Source/WebCore/html/canvas/CanvasStyle.cpp
M Source/WebCore/testing/Internals.cpp
Log Message:
-----------
2D context stroke, fill color parsing spends time resolving script execution
context
https://bugs.webkit.org/show_bug.cgi?id=292604
rdar://150757978
Reviewed by Simon Fraser.
General parsing CSS colors needs the CSS value pool from script
execution context. The fast path does not need this, but 2D context
code would resolve the context anyway. For significant number of
strokeStyle/fillStyle assignments, this would result in significant
amount of work.
Simplify the fast/slow path invocation by exposing the specific fast
path function. There's only few call sites and the previous functor
based approach resulted in more complex and less efficient code.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
(WebCore::CSSPropertyParserHelpers::parseColorRaw):
(WebCore::CSSPropertyParserHelpers::parseColorRawSlow): Deleted.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorInlines.h:
(WebCore::CSSPropertyParserHelpers::parseColorRawFast):
(WebCore::CSSPropertyParserHelpers::parseColorRaw):
* Source/WebCore/html/ColorInputType.cpp:
(WebCore::parseColorValue):
(WebCore::colorParsingParameters): Deleted.
* Source/WebCore/html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyleColorResolutionDelegate::currentColor const):
(WebCore::parseColor):
(WebCore::elementlessColorParsingParameters): Deleted.
(WebCore::colorParsingParameters): Deleted.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setUnderPageBackgroundColorOverride):
Canonical link: https://commits.webkit.org/294607@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
