Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9e82aedf3a00f3c3b05538b623c70f8ff915209a
https://github.com/WebKit/WebKit/commit/9e82aedf3a00f3c3b05538b623c70f8ff915209a
Author: Joshua Hoffman <[email protected]>
Date: 2025-05-07 (Wed, 07 May 2025)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm
Log Message:
-----------
AX: Start caching default values for Font and TextColor on the isolated tree
https://bugs.webkit.org/show_bug.cgi?id=292628
rdar://150788269
Reviewed by Tyler Wilcock.
We are caching TextColor and Font on almost every static text object, since
there is no reasonable predetermined default for all web pages.
To be smarter about this, we can instead cache these properties only when
they differ from their ancestor. This significantly reduces the number of
times we need to cache these properties, since most often these are
inhereted from an ancestor.
I confirmed that these changes don't have a perf impact by taking a few
samples.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::setProperty):
(WebCore::AXIsolatedObject::colorAttributeValue const):
(WebCore::AXIsolatedObject::fontAttributeValue const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::setDefaultTextColor):
(WebCore::AXIsolatedTree::defaultTextColor):
(WebCore::AXIsolatedTree::setDefaultFont):
(WebCore::AXIsolatedTree::defaultFont):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/294634@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
