Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8dd5078272deab17b0ff30a912ce2dcd15bd294a
https://github.com/WebKit/WebKit/commit/8dd5078272deab17b0ff30a912ce2dcd15bd294a
Author: Wenson Hsieh <[email protected]>
Date: 2025-05-07 (Wed, 07 May 2025)
Changed paths:
M Source/WebKit/Platform/cocoa/WebPrivacyHelpers.h
Log Message:
-----------
REGRESSION (283464@main): Several ResourceLoadStatistics API tests crash
under `ListDataController<…>::setCachedListDataForTesting`
https://bugs.webkit.org/show_bug.cgi?id=292680
rdar://150609463
Reviewed by Abrar Rahman Protyasha.
When running the following API tests:
• ResourceLoadStatistics.StorageAccessPromptSiteWithQuirk
• ResourceLoadStatistics.StorageAccessPromptSiteWithTrigger
• ResourceLoadStatistics.StorageAccessSupportMultipleSubFrameDomains
…we crash under
`StorageAccessPromptQuirkController::setCachedListDataForTesting`. For reasons
still
unknown, this:
- Only occurs when the definition of `ListDataController::setCachedListData`
is inlined.
- Crashes when attempting to invoke the virtual method
`didUpdateCachedListData()` on
`StorageAccessPromptQuirkController`.
Additionally, the implementation of `setCachedListData` seems to only be
inlined in local
engineering builds, as opposed to production builds (based on `nm` output).
To sidestep this issue, move the virtual method `didUpdateCachedListData()`
into the concrete base
class on `ListDataControllerBase`, instead of the templated
`ListDataController`.
* Source/WebKit/Platform/cocoa/WebPrivacyHelpers.h:
(WebKit::ListDataControllerBase::didUpdateCachedListData):
(WebKit::ListDataController::didUpdateCachedListData): Deleted.
Canonical link: https://commits.webkit.org/294651@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
