Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1241768fd694be6850ad1fe896566206c31e47aa
https://github.com/WebKit/WebKit/commit/1241768fd694be6850ad1fe896566206c31e47aa
Author: Pascoe <[email protected]>
Date: 2025-05-08 (Thu, 08 May 2025)
Changed paths:
M Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h
M Source/WebKit/UIProcess/API/APINavigation.cpp
M Source/WebKit/UIProcess/API/APINavigation.h
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp
M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm
Log Message:
-----------
Add timeout for safe browsing check
https://bugs.webkit.org/show_bug.cgi?id=287851
rdar://142507598
Reviewed by Alex Christensen.
In the case where the safe browsing daemon hangs on our request, we
should allow requests to go through after waiting 2x the amount of time
the response took. This implements such behavior and adds API tests for it.
* Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h:
* Source/WebKit/UIProcess/API/APINavigation.cpp:
(API::Navigation::resetRequestStart):
* Source/WebKit/UIProcess/API/APINavigation.h:
(API::Navigation::setSafeBrowsingCheckOngoing):
(API::Navigation::safeBrowsingCheckOngoing const):
(API::Navigation::setSafeBrowsingWarning):
(API::Navigation::safeBrowsingWarning const):
(API::Navigation::requestStart const):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults):
* Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(+[DelayedLookupContext sharedLookupContext]):
(-[DelayedLookupContext lookUpURL:completionHandler:]):
(TEST(SafeBrowsing, HangTimeout)):
(TEST(SafeBrowsing, PostResponse)):
(TEST(SafeBrowsing, PreresponseSafeBrowsingWarning)):
Canonical link: https://commits.webkit.org/294690@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
