Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e5158bf2619c3fddaf0fb11d707a0b1b120ea6b7
https://github.com/WebKit/WebKit/commit/e5158bf2619c3fddaf0fb11d707a0b1b120ea6b7
Author: Ada Chan <[email protected]>
Date: 2025-05-13 (Tue, 13 May 2025)
Changed paths:
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
Log Message:
-----------
Fix leak of previous m_modelPlayer in HTMLModelElement::createModelPlayer()
https://bugs.webkit.org/show_bug.cgi?id=292909
rdar://150500615
Reviewed by Mike Wyrzykowski.
HTMLModelElement::m_modelPlayer can be non-null when createModelPlayer()
is called, resulting in the leak of the previous model player. To fix this,
delete the previous model player before overwriting m_modelPlayer with the
new one.
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::createModelPlayer):
(WebCore::HTMLModelElement::unloadModelPlayer):
We should also call deleteModelPlayer() here rather than just setting
m_modelPlayer to null.
Canonical link: https://commits.webkit.org/294851@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
