Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80d1a66176baafcd33e459d95f1c63327b4942f6 https://github.com/WebKit/WebKit/commit/80d1a66176baafcd33e459d95f1c63327b4942f6 Author: Megan Gardner <megan_gard...@apple.com> Date: 2025-05-13 (Tue, 13 May 2025)
Changed paths: M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: ----------- TextIndicator needs to update with more complicated window changes. https://bugs.webkit.org/show_bug.cgi?id=292775 rdar://151011352 Reviewed by Wenson Hsieh. In preparation for having the text indicator update with more complicated window changes, we need to move it into the main window. This also unifies the path for text indicator to be the same on iOS and macOS. Behavior should be mostly unchanged, but you will note that the bounce will no longer travel outside the main widow, which will only come up when the indicator is close to the edge. This is a tradeoff we are willing to make so that the indicator can be more closely tied to more complicated window updates, and will not be out of sync during those transitions. * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::renewGState): (WebKit::WebViewImpl::setTextIndicator): (WebKit::WebViewImpl::updateTextIndicator): (WebKit::WebViewImpl::clearTextIndicatorWithAnimation): (WebKit::WebViewImpl::setTextIndicatorAnimationProgress): (WebKit::WebViewImpl::teardownTextIndicatorLayer): (WebKit::WebViewImpl::startTextIndicatoreFadeOut): Canonical link: https://commits.webkit.org/294860@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes