Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46bcbfb3cf5ebc591f1c02f41c178e1d13062554
      
https://github.com/WebKit/WebKit/commit/46bcbfb3cf5ebc591f1c02f41c178e1d13062554
  Author: Tadeu Zagallo <[email protected]>
  Date:   2025-05-19 (Mon, 19 May 2025)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTBuilder.cpp
    M Source/WebGPU/WGSL/AST/ASTBuilder.h

  Log Message:
  -----------
  [WGSL] Remove arena allocation
https://bugs.webkit.org/show_bug.cgi?id=292928
rdar://150858621

Reviewed by Mike Wyrzykowski.

Keep the lifetime tracking in the ASTBuilder, but allocate each node 
individually
with system malloc instead of allocating arenas. We're currently seeing some 
crashes
under the arena allocation that we can't find the root cause for, and we hope 
that
by using system malloc instead it might help us identify the issue.

* Source/WebGPU/WGSL/AST/ASTBuilder.cpp:
(WGSL::AST::Builder::Builder):
(WGSL::AST::Builder::saveCurrentState):
(WGSL::AST::Builder::restore):
(WGSL::AST::Builder::~Builder): Deleted.
(WGSL::AST::Builder::allocateArena): Deleted.
(WGSL::AST::Builder::canPoison): Deleted.
* Source/WebGPU/WGSL/AST/ASTBuilder.h:
(WGSL::AST::Builder::construct):
(WGSL::AST::Builder::alignSize): Deleted.
(): Deleted.

Canonical link: https://commits.webkit.org/295087@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to