Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 382603413833803faad008d6406b28e3e886dd39
https://github.com/WebKit/WebKit/commit/382603413833803faad008d6406b28e3e886dd39
Author: Alan Baradlay <[email protected]>
Date: 2025-05-19 (Mon, 19 May 2025)
Changed paths:
M Source/WebCore/WebCore.order
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
Log Message:
-----------
[Cleanup] Remove redundant hashmap lookup from
RenderBlock::clearPercentHeightDescendantsFrom
https://bugs.webkit.org/show_bug.cgi?id=293093
Reviewed by Antti Koivisto.
RenderBlock::clearPercentHeightDescendantsFrom() has the old style logic of
if (contains())
remove()
Let's just call remove (take) as constructing an empty HashSet is cheap.
-also remove the *ifNeeded variant for the exact same reason.
* Source/WebCore/WebCore.order:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePercentHeightDescendant):
(WebCore::RenderBlock::hasPercentHeightContainerMap):
(WebCore::RenderBlock::clearPercentHeightDescendantsFrom):
(WebCore::RenderBlock::hasPercentHeightDescendant): Deleted.
(WebCore::RenderBlock::removePercentHeightDescendantIfNeeded): Deleted.
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::move):
(WebCore::RenderTreeBuilder::moveChildren):
Canonical link: https://commits.webkit.org/295127@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
