Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9e0323c7869de9670c8edafaea6e35f5b3e91136
https://github.com/WebKit/WebKit/commit/9e0323c7869de9670c8edafaea6e35f5b3e91136
Author: Youenn Fablet <[email protected]>
Date: 2025-05-21 (Wed, 21 May 2025)
Changed paths:
M LayoutTests/fast/mediastream/enumerate-speaker.html
M LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id.html
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/Modules/mediastream/MediaDevices.h
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
Log Message:
-----------
Expose a default system speaker device
rdar://151761469
https://bugs.webkit.org/show_bug.cgi?id=293349
Reviewed by Eric Carlson.
As can be seen in websites like Webex, providing an explicit system default
speaker device is useful to users.
That way, users can explicitly select to follow the system default speaker.
We use "default" as the deviceId and concatenate "Default - " with the actual
default speaker name.
This heuristic is the same as Chrome's approach.
Manually tested on Webex and covered by updated layout test.
* LayoutTests/fast/mediastream/enumerate-speaker.html:
* LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id.html:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::deviceIdToPersistentId const):
(WebCore::createDefaultSpeakerAsSpecificDevice):
(WebCore::MediaDevices::exposeDevices):
* Source/WebCore/Modules/mediastream/MediaDevices.h:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::defaultSystemSpeakerLabel):
* Source/WebCore/platform/LocalizedStrings.h:
Canonical link: https://commits.webkit.org/295206@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
