Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7587ce4857c86152a86a0ddf8fb3b1416d65d638
      
https://github.com/WebKit/WebKit/commit/7587ce4857c86152a86a0ddf8fb3b1416d65d638
  Author: Richard Robinson <[email protected]>
  Date:   2025-05-21 (Wed, 21 May 2025)

  Changed paths:
    M Source/WebKit/Modules/Internal/WebKitInternal.h
    M 
Source/WebKit/UIProcess/Cocoa/GroupActivities/GroupActivitiesSessionNotifier.mm
    A Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.h
    A Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    R Source/WebKit/WebKitSwift/GroupActivities/WKGroupSession.h
    R Source/WebKit/WebKitSwift/GroupActivities/WKGroupSession.swift
    M Source/WebKit/WebKitSwift/WebKitSwift.h

  Log Message:
  -----------
  [Swift in WebKit] Move GroupActivities code from WebKitSwift to WebKit
rdar://151568946
https://bugs.webkit.org/show_bug.cgi?id=293203

Reviewed by Aditya Keerthi.

Move GroupActivities-related code to WebKit instead of WKS.

* Source/WebKit/Modules/Internal/WebKitInternal.h:

- Add WKGroupSession to the internal module

* 
Source/WebKit/UIProcess/Cocoa/GroupActivities/GroupActivitiesSessionNotifier.mm:

- Remove soft linking

* Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.h: Renamed from 
Source/WebKit/WebKitSwift/GroupActivities/WKGroupSession.h.
* Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift: Renamed 
from Source/WebKit/WebKitSwift/GroupActivities/WKGroupSession.swift.

- Import the WebKit internal module instead of WKS
- Fix a spacing typo
- Add an empty deinit to all types to workaround a compiler bug on older Swift 
compilers that happens when using `@_objcImplementation`
- Remove the body of the deinit of `WKGroupSessionObserver` for several 
reasons: (1) Due to a likely compiler bug, there is no way of being able to 
access `incomingSessionsTask`, and (2) this is actually dead code, since the 
type is used by a singleton class that is never destroyed.

* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebKitSwift/WebKitSwift.h:

- Remove soft linking

Canonical link: https://commits.webkit.org/295228@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to