Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1d055ce00488eb9b591129eb6a913175cd678f12
https://github.com/WebKit/WebKit/commit/1d055ce00488eb9b591129eb6a913175cd678f12
Author: Joshua Hoffman <josh_hoff...@apple.com>
Date: 2025-05-23 (Fri, 23 May 2025)
Changed paths:
A LayoutTests/accessibility/aria-expanded-links-expected.txt
A LayoutTests/accessibility/aria-expanded-links.html
M LayoutTests/platform/glib/TestExpectations
M
LayoutTests/platform/glib/accessibility/aria-expanded-supported-roles-expected.txt
M
LayoutTests/platform/mac/accessibility/aria-expanded-supported-roles-expected.txt
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXSearchManager.cpp
M Source/WebCore/accessibility/AccessibilityImageMapLink.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilitySVGObject.cpp
M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/page/InteractionRegion.cpp
Log Message:
-----------
AX: aria-expanded should be supported on WebCoreLink
https://bugs.webkit.org/show_bug.cgi?id=293452
rdar://141163086
Reviewed by Chris Fleizach.
SupportsExpanded did not handle WebCoreLink, meaning that links wouldn't report
their
expanded status to ATs. Per the spec, links are a valid role for aria-expanded,
so
we should return true for all WebCoreLinks.
Since there is no meaningful difference between WebCoreLink and Link, this PR
also
removes all references to WebCoreLink, and switches to using Link everywhere.
* LayoutTests/accessibility/aria-expanded-links-expected.txt: Added.
* LayoutTests/accessibility/aria-expanded-links.html: Added.
*
LayoutTests/platform/glib/accessibility/aria-expanded-supported-roles-expected.txt:
*
LayoutTests/platform/mac/accessibility/aria-expanded-supported-roles-expected.txt:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isLink const):
(WebCore::AXCoreObject::isImplicitlyInteractive const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::accessibilityRoleToString):
* Source/WebCore/accessibility/AXSearchManager.cpp:
(WebCore::AXSearchManager::matchForSearchKeyAtIndex):
* Source/WebCore/accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::determineAccessibilityRole):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::localizedActionVerb const):
(WebCore::AccessibilityObject::actionVerb const):
(WebCore::initializeRoleMap):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::hasTextContent const):
(WebCore::AccessibilityObject::hasAttributedText const):
* Source/WebCore/accessibility/AccessibilitySVGObject.cpp:
(WebCore::AccessibilitySVGObject::determineAccessibilityRole):
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::roleIsTextType):
(WebCore::atspiRole):
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::Accessibility::createPlatformRoleMap):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowAccessibilityRoleAsPointerCursorReplacement):
Canonical link: https://commits.webkit.org/295356@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
