Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cb5ea52ae67d16efb5f25051093db2bb72f83c2
      
https://github.com/WebKit/WebKit/commit/9cb5ea52ae67d16efb5f25051093db2bb72f83c2
  Author: Yusuke Suzuki <ysuz...@apple.com>
  Date:   2025-05-23 (Fri, 23 May 2025)

  Changed paths:
    A JSTests/stress/new-array-with-spread-ai-structure.js
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h

  Log Message:
  -----------
  [JSC] DFG AI's NewArrayWithSpread structures should be narrowed down
https://bugs.webkit.org/show_bug.cgi?id=291994
rdar://150417620

Reviewed by Yijia Huang.

Since the subsequent path is doing optimizations based on proven values
from AI, AI always needs to produce narrower values as compiler pipeline
goes. NewArrayWithSpread was not doing that Since

    NewArrayWithSpread(Spread(...))

    says CoW array while if its Spread gets converted to PhantomSpread,

    NewArrayWithSpread(PhantomSpread(non-PhantomNewArrayBuffer))

    then it says it is non-CoW array.

For conservative cases, we should list all structures.

* JSTests/stress/new-array-with-spread-ai-structure.js: Added.
(opt):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

Canonical link: https://commits.webkit.org/295366@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to