Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e5d8d9678c91bb0d98ca391b2447c206cdf49acb
https://github.com/WebKit/WebKit/commit/e5d8d9678c91bb0d98ca391b2447c206cdf49acb
Author: Matt Woodrow <[email protected]>
Date: 2025-05-26 (Mon, 26 May 2025)
Changed paths:
M LayoutTests/TestExpectations
A
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/column-span-during-transition-doesnt-skip-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/column-span-during-transition-doesnt-skip-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/column-span-during-transition-doesnt-skip.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/dom/ViewTransition.h
M Source/WebCore/rendering/RenderFragmentContainer.h
M Source/WebCore/rendering/RenderFragmentedFlow.cpp
M Source/WebCore/rendering/RenderFragmentedFlow.h
M Source/WebCore/rendering/RenderMultiColumnSet.cpp
M Source/WebCore/rendering/RenderMultiColumnSet.h
Log Message:
-----------
View transitions don't ignore fragmented content.
https://bugs.webkit.org/show_bug.cgi?id=265734
<rdar://119081264>
Reviewed by Alan Baradlay
Check for fragmented content when looking up view-transition-name properties in
the new/old state captures, and ignore names belonging to fragmented content.
If an element becomes fragmented in the middle of the transition, abort.
Add handing for the case where the content belongs to a single
RenderMultiColumnSet (and thus isn't fragmented in the render tree), but still
is visually fragmented across columns by adding a new lookup that works
similarly to absoluteQuadsForBox.
Adds new tests for content spanning across a fragmentainer.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/column-span-during-transition-doesnt-skip-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/column-span-during-transition-doesnt-skip-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/column-span-during-transition-doesnt-skip.html:
Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::rendererIsFragmented):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):
(WebCore::ViewTransition::handleTransitionFrame):
(WebCore::ViewTransition::updatePseudoElementStylesRead):
* Source/WebCore/dom/ViewTransition.h:
* Source/WebCore/rendering/RenderFragmentContainer.h:
(WebCore::RenderFragmentContainer::contentRectSpansFragments const):
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::boxIsFragmented const):
* Source/WebCore/rendering/RenderFragmentedFlow.h:
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::contentRectSpansFragments const):
* Source/WebCore/rendering/RenderMultiColumnSet.h:
Canonical link: https://commits.webkit.org/295430@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
