Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb01416d4c91349e7361b1b98f804517f9c3c679
      
https://github.com/WebKit/WebKit/commit/bb01416d4c91349e7361b1b98f804517f9c3c679
  Author: Sammy Gill <[email protected]>
  Date:   2025-05-27 (Tue, 27 May 2025)

  Changed paths:
    M Source/WebCore/rendering/GridBaselineAlignment.cpp
    M Source/WebCore/rendering/GridBaselineAlignment.h
    M Source/WebCore/rendering/GridLayoutFunctions.cpp
    M Source/WebCore/rendering/GridLayoutFunctions.h
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  -----------
  [Grid] Remove GridAxis and stop using it from GridBaselineAlignment.
https://bugs.webkit.org/show_bug.cgi?id=293493
rdar://151930667

Reviewed by Alan Baradlay.

This is the final patch in the series of cleanups to stop using GridAxis
and to remove it. Instead, we now use GridTrackSizingDirection as the
type of alignment context (i.e. a grid row or grid column), which is what
GridAxis was basically doing. In each function where this was being used,
we just changed uses of:
- GridAxis::GridColumnAxis -> GridTrackSizingDirection::ForRows
- GridAxis::GridRowAxis -> GridTrackSizingDirection::ForColumns

I also renamed m_row/columnAxisBaselineAlignmentStates to
m_row/columnAlignmentContextStates to reflect this change.

This change makes the code simpler since we do not have to worry about
converting between these two enums in different parts of the code. As a
result, we can remove the enum and the helper functions that were used
to convert between it and GridTrackSizingDirection.

Canonical link: https://commits.webkit.org/295463@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to