Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e55da04f7eae004a6ea0a26eb1d0c2cef7fd4f29
      
https://github.com/WebKit/WebKit/commit/e55da04f7eae004a6ea0a26eb1d0c2cef7fd4f29
  Author: Sam Weinig <[email protected]>
  Date:   2025-05-30 (Fri, 30 May 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dasharray-computed-expected.txt
    M LayoutTests/svg/css/parse-calc-length-expected.txt
    M LayoutTests/svg/css/parse-calc-length.html
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/SVGRenderStyle.h
    M Source/WebCore/rendering/style/SVGRenderStyleDefs.h
    M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
    M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.h
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleBuilderCustom.h
    M Source/WebCore/style/StyleExtractorConverter.h
    M Source/WebCore/style/StyleExtractorCustom.h
    M Source/WebCore/style/StyleExtractorSerializer.h
    M Source/WebCore/style/StyleInterpolationFunctions.h
    M Source/WebCore/style/StyleInterpolationWrappers.h

  Log Message:
  -----------
  Stop using SVGLengthValue in SVGRenderStyle
https://bugs.webkit.org/show_bug.cgi?id=293689

Reviewed by Simon Fraser.

Replace SVGLengthValue with Length in SVGRenderStyle, updating
the stroke-dasharray and baseline-shift properties.

SVGLengthValue is only needed for DOM exposed properties.

Also made the setter for stroke-dasharray not require a copy
by updating it to take an r-value. This had the consequence
of making it no longer with with the default animation wrapper
so custom one was required.

* 
LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dasharray-computed-expected.txt:
* LayoutTests/svg/css/parse-calc-length-expected.txt:
* LayoutTests/svg/css/parse-calc-length.html:
    - Update tests showing proper calc support.

* Source/WebCore/css/CSSProperties.json:
    - Update 'stroke-dasharray' to use new custom animation wrapper.

* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/SVGRenderStyle.h:
* Source/WebCore/rendering/style/SVGRenderStyleDefs.h:
    - Update property definitions.

* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
* Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp:
* Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:
* Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.h:
    - Update length resolutions.

* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleBuilderCustom.h:
    - Simplify conversion using existing conversions.

* Source/WebCore/style/StyleExtractorConverter.h:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/StyleExtractorSerializer.h:
    - Simplify conversion using existing extractors.

* Source/WebCore/style/StyleInterpolationFunctions.h:
    - Update to Length blendFunc.

* Source/WebCore/style/StyleInterpolationWrappers.h:
    - Update BaselineShiftWrapper to work with Length
      and add StrokeDashArrayWrapper.

Canonical link: https://commits.webkit.org/295618@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to