Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa6420a141f77f712383839cbe16b98519e472b1
      
https://github.com/WebKit/WebKit/commit/fa6420a141f77f712383839cbe16b98519e472b1
  Author: Megan Gardner <[email protected]>
  Date:   2025-05-30 (Fri, 30 May 2025)

  Changed paths:
    M Source/WebCore/editing/DictionaryPopupInfo.h
    M Source/WebCore/editing/cocoa/DictionaryLookup.mm
    M Source/WebCore/page/TextIndicator.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm

  Log Message:
  -----------
  Switch to textIndicator for DictionaryPopupInfo.
https://bugs.webkit.org/show_bug.cgi?id=293784
rdar://152286761

Reviewed by Tim Horton.

Continuing to convert from textIndicatorData to
TextIndicator.

* Source/WebCore/editing/DictionaryPopupInfo.h:
* Source/WebCore/editing/cocoa/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):
* Source/WebCore/page/TextIndicator.h:
(WebCore::TextIndicator::contentImageWithoutSelectionRectInRootViewCoordinates 
const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):
(WebKit::PDFPlugin::dictionaryPopupInfoForSelection):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::dictionaryPopupInfoForSelection):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::dictionaryPopupInfoForRange):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::remoteDictionaryPopupInfoToRootView):
* Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm:
(+[WebImmediateActionController 
_dictionaryPopupInfoForRange:inFrame:indicatorOptions:transition:]):

Canonical link: https://commits.webkit.org/295636@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to