Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae1d259cd69f42dc13a09fc1c6e127baa4ed5662
      
https://github.com/WebKit/WebKit/commit/ae1d259cd69f42dc13a09fc1c6e127baa4ed5662
  Author: Richard Robinson <[email protected]>
  Date:   2025-05-31 (Sat, 31 May 2025)

  Changed paths:
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUProcessExtension.swift
    M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift
    M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentProcessExtension.swift
    M Source/WebKit/UIProcess/API/Cocoa/ObjectiveCBlockConversions.swift
    M Source/WebKit/UIProcess/API/Cocoa/WKContextMenuElementInfoAdapter.swift
    M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences+Extras.swift
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore+SwiftOverlay.swift
    M Source/WebKit/UIProcess/API/Cocoa/WebKitSwiftOverlay.swift
    M Source/WebKit/UIProcess/API/Swift/URLSchemeHandler.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage+BackForwardList.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage+Configuration.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage+DialogPresenting.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage+Navigation.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDeciding.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage+NavigationPreferences.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage.swift
    M Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift
    M Source/WebKit/UIProcess/Cocoa/RunLoopQueue.swift
    M Source/WebKit/UIProcess/Cocoa/TextExtraction/WKTextExtractionItem.swift
    M 
Source/WebKit/UIProcess/Cocoa/TextExtraction/WKWebView+TextExtraction.swift
    M Source/WebKit/UIProcess/Cocoa/WKNavigationDelegateAdapter.swift
    M Source/WebKit/UIProcess/Cocoa/WKScrollGeometryAdapter.swift
    M Source/WebKit/UIProcess/Cocoa/WKUIDelegateAdapter.swift
    M Source/WebKit/UIProcess/Cocoa/WebPageWebView.swift

  Log Message:
  -----------
  [Swift in WebKit] Use swift-format to lint WebKit code
https://bugs.webkit.org/show_bug.cgi?id=293842
rdar://152347799

Reviewed by Abrar Rahman Protyasha.

Work towards having consistently formatted and linted Swift code; lint the 
WebKit codebase
for improved correctness and readability.

This is excluding WebKitSwift for now.

* Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUProcessExtension.swift:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentProcessExtension.swift:
* Source/WebKit/UIProcess/API/Cocoa/ObjectiveCBlockConversions.swift:

- Replace block quotes.

* Source/WebKit/UIProcess/API/Cocoa/WKContextMenuElementInfoAdapter.swift:

- Ignore AllPublicDeclarationsHaveDocumentation due to SPI.

* Source/WebKit/UIProcess/API/Cocoa/WebKitSwiftOverlay.swift:

- Replace block quotes.
- Ignore AllPublicDeclarationsHaveDocumentation due to pre-existing API 
documentation.
- Use null coalescing instead of force-unwrapping
- Add missing documentation for some WKWebExtension initializers, based on 
their Objective-C documentation.
- Add missing documentation for `WKWebsiteDataStore.proxyConfigurations` based 
on its Objective-C documentation.

* Source/WebKit/UIProcess/API/Swift/URLSchemeHandler.swift:

- Add missing docs.

* Source/WebKit/UIProcess/API/Swift/WebPage+BackForwardList.swift:

- Add missing docs.

* Source/WebKit/UIProcess/API/Swift/WebPage+Configuration.swift:

- Add missing docs.
- Fix variable naming.

* Source/WebKit/UIProcess/API/Swift/WebPage+DialogPresenting.swift:

- Fix doc format.

* Source/WebKit/UIProcess/API/Swift/WebPage+Navigation.swift:

- Fix doc format.
- Ignore AllPublicDeclarationsHaveDocumentation due to SPI.

* Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDeciding.swift:

- Ignore AllPublicDeclarationsHaveDocumentation due to SPI.
- Add a FIXME to SPI that should be API.

* Source/WebKit/UIProcess/API/Swift/WebPage+NavigationPreferences.swift:

- Fix variable naming

* Source/WebKit/UIProcess/API/Swift/WebPage.swift:

- Fix doc format
- Fix parameter and variable naming
- Add missing docs
- Ignore AllPublicDeclarationsHaveDocumentation in some places due to SPI.

* Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift:

- Fix variable naming
- Justify force-unwrapping

* Source/WebKit/UIProcess/Cocoa/RunLoopQueue.swift:

- Add documentation (even though this is SPI).

* Source/WebKit/UIProcess/Cocoa/TextExtraction/WKTextExtractionItem.swift:

- Fix variable naming.

* Source/WebKit/UIProcess/Cocoa/TextExtraction/WKWebView+TextExtraction.swift:

- Ignore NoLeadingUnderscores because it is a false-positive.

* Source/WebKit/UIProcess/Cocoa/WKNavigationDelegateAdapter.swift:

- Ignore NoLeadingUnderscores because it is a false-positive.

* Source/WebKit/UIProcess/Cocoa/WKScrollGeometryAdapter.swift:
* Source/WebKit/UIProcess/Cocoa/WKUIDelegateAdapter.swift:
* Source/WebKit/UIProcess/Cocoa/WebPageWebView.swift:

- Ignore AllPublicDeclarationsHaveDocumentation due to SPI.

Canonical link: https://commits.webkit.org/295655@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to